Reject Long Identifier

Review ask

As a clinical trial statistician or programmer, answer two short questions in Your review: the task and the inputs. Agreeing with both approves this benchmark; disagreeing with either needs a comment. Propose a fix with the Edit button on any source file, or add it to your comments.

We suggest spending no more than 5 minutes on a review. The other tabs beside Your review are background for assessment, not under review.

Summary

EditUnder reviewWhat this benchmark means

README.md

Public entries: Python and R. Passing coverage requires an installed inventory.

Goal: build one demographics record per subject, carrying the unique subject identifier (USUBJID) and the site identifier (SITEID).

Input: collected demographics records, each carrying the study identifier, the site identifier (SITEID) and the subject number (SUBJID).

Variables:

USUBJID would be the study, site and subject identifiers joined by hyphens, such as CATH-UCSD-0001; a record missing any of the three parts stops the run.
SITEID would be the study site identifier, as collected.

Note: the subject identifier must fit in 20 characters on every record. A site identifier long enough to push it past that limit rejects the run after the dataset completes, so no artifact is accepted.

How to fix

Decide which is authoritative: the width the study declares, or the site identifier the data carries. If the site identifier can be shortened at source, correct it there, so that every dataset referring to the subject keeps one value:

CATH,0003,STMARY

If the long site identifier is correct, raise the declared width to one that fits the longest value the study can produce, and change it wherever the subject identifier is described:

- name: USUBJID
  type: str
  derivation:
    str_template: "{DM_RAW.STUDYID}-{DM_RAW.SITEID}-{DM_RAW.SUBJID}"
  verifications:
    - max_length:
        max: 30

Do not lower the bound below the values the study produces merely to make this input pass. A subject identifier that no longer fits its stated width is a defect wherever it is carried.

Expected failure

Editthe run is rejected; no artifact is accepted

expected/error.yaml

phase: verification
condition: length_failed
rule: CHECK-8

expected/error.yaml

phase: verification
condition: length_failed
spec_paths:
  - columns.USUBJID.verifications[0].max_length
rule: CHECK-8
context:
  column: USUBJID
  max: 20
  failure_count: 1
  keys:
    - STUDYID: CATH
      USUBJID: CATH-STMARYSMONTREAL-0003

YAML specification

1 spec file

spec.yaml

Edit40 lines

1yamaa: "1.0"2type: spec3model: SDTM4domain: DM5keys: [STUDYID, USUBJID]6input:7  DM_RAW: input/dm_raw.csv89output:10  path: dm.csv11  columns: [STUDYID, USUBJID, SUBJID, SITEID]1213columns:14  - name: STUDYID15    type: str16    label: Study Identifier17    derivation: DM_RAW.STUDYID1819  - name: USUBJID20    type: str21    label: Unique Subject Identifier22    # STUDYID-SITEID-SUBJID. With no missing: value, a record missing any23    # part stops the run.24    derivation:25      str_template: "{DM_RAW.STUDYID}-{DM_RAW.SITEID}-{DM_RAW.SUBJID}"26    # A long site identifier pushes the joined value past 20 characters,27    # which fails once the dataset is complete.28    verifications:29      - max_length:30          max: 203132  - name: SUBJID33    type: str34    label: Subject Identifier for the Study35    derivation: DM_RAW.SUBJID3637  - name: SITEID38    type: str39    label: Study Site Identifier40    derivation: DM_RAW.SITEID

Inputs

Under review1 source file

input/dm_raw.csv

Edit3 rows

input/dm_raw.csv
STUDYID	SUBJID	SITEID
CATH	0001	UCSD
CATH	0002	MCGILL
CATH	0003	STMARYSMONTREAL

Unexpected Output

Under reviewNo artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Human review and assessment

Variable Name	Variable Label	Type	Origin	Conversion Definition	Variable Type	Variable Order
STUDYID	Study Identifier	Char	Collected	Copy value from DM_RAW.STUDYID.	SDTM	1
USUBJID	Unique Subject Identifier	Char	Derived	Fill the template "{DM_RAW.STUDYID}-{DM_RAW.SITEID}-{DM_RAW.SUBJID}".	SDTM	2
SUBJID	Subject Identifier for the Study	Char	Collected	Copy value from DM_RAW.SUBJID.	SDTM	3
SITEID	Study Site Identifier	Char	Collected	Copy value from DM_RAW.SITEID.	SDTM	4

Version	Date	Author	Description
1.7	2026-10-20	yamaa docs build	Read a specification in the 1.0 surface as its 0.5 counterpart; state that missing values stay missing where a mapping declares no missing handler, and leave out a declared missing answer that restates a handler's default
1.6	2026-10-17	yamaa docs build	Describe collected date parts written as ISO 8601 date text and times of day counted in seconds since midnight
1.5	2026-10-17	yamaa docs build	Name collected precision in words instead of letter codes; state imputation fallbacks, minimum source precision, bounds ignored outside the collected period, and invalid text with no handler as an error; describe date and datetime shifts, imputation flag codes, and partial text giving no date part
1.4	2026-10-15	yamaa docs build	State datetime precision codes through the hour and minute, and complete only the time parts a collected datetime lacks
1.3	2026-09-29	yamaa docs build	Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.2	2026-09-29	yamaa docs build	Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.1	2026-09-29	yamaa docs build	Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0		yamaa docs build	Initial generation from spec.yaml

How to fix

input/dm_raw.csv

Your review

Mapping spec