Reject an undefined visit ordering

Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
Inputs: Do they trigger the failure for the reason the summary gives?
Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

EditUnder reviewWhat this benchmark means

README.md

Goal: compute VISITSEQ, the sequence number of each subject's vital-sign visits in analysis visit order.

Input: vital-sign visit records identified by subject (USUBJID) and analysis visit number (AVISITN).

Variables:

VISITSEQ would number the subject's visits from one in analysis visit order. It names that ordering with a misspelling that matches no defined ordering, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Correct the misspelled reference to the complete declared window:

row_number:
  window: VISIT_ORDER

If a different ordering is intended, declare it as its own complete window or write its settings inline.

Expected failure

Editthe run is rejected; no artifact is accepted

expected/error.yaml

phase: validation
condition: unknown_window
requirement: REQ-1253

expected/error.yaml

phase: validation
condition: unknown_window
spec_paths:
  - columns.VISITSEQ.derivation.row_number.window
requirement: REQ-1253
context:
  window: VISITS_ORDER

YAML specification

1 spec file

spec.yaml

Edit34 lines

1schema_version: "1.0"2domain: ADVS3keys: [USUBJID, AVISITN]4input:5  VS: {path: input/vs.csv, types: {AVISITN: int}}67output:8  path: advs.csv9  columns: [USUBJID, AVISITN, VISITSEQ]1011windows:12  VISIT_ORDER:13    group_by: [USUBJID]14    order_by: [AVISITN]1516columns:17  - name: USUBJID18    type: str19    label: Unique Subject Identifier20    derivation: VS.USUBJID2122  - name: AVISITN23    type: int24    label: Analysis Visit (N)25    derivation: VS.AVISITN2627  - name: VISITSEQ28    type: int29    label: Visit Sequence Number30    derivation:31      row_number:32        # VISITS_ORDER misspells VISIT_ORDER, the one declared window, so the33        # spec is rejected before any data is read.34        window: VISITS_ORDER

Inputs

Under review1 source file

input/vs.csv

Edit5 rows

input/vs.csv
USUBJID	AVISITN
	1
	2
	3
	1
	2

Unexpected Output

Under reviewNo artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Dataset Name	Variable Name	Variable Label	Type	Computational Method	Origin
ADVS	USUBJID	Unique Subject Identifier	character	Copy value from VS.USUBJID.	Predecessor
ADVS	AVISITN	Analysis Visit (N)	numeric	Copy value from VS.AVISITN.	Predecessor
ADVS	VISITSEQ	Visit Sequence Number	numeric	Row number using window VISITS_ORDER.	Derived

Version	Date	Author	Description
1.3	2026-09-29	yamaa docs build	Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.2	2026-09-29	yamaa docs build	Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.1	2026-09-29	yamaa docs build	Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0		yamaa docs build	Initial generation from spec.yaml

How to fix

input/vs.csv

Comments

Mapping spec