Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build a subject listing carrying SITEID.

Input: collected subject listing stored as input/dm.txt, holding SITEID.

Variables:

  • SITEID would be the site the subject enrolled at, taken directly from the collected listing.

The file's .txt ending names neither of the two formats a listing can be read from, .csv (comma-separated text) or .parquet, so nothing says how to read it. Its bytes happen to use commas today, but a reader that decided by looking inside could read the same file differently another time or differently from the next reader. The run is rejected before any data is read, so no artifact is accepted.

How to fix

Store the listing under the name of the format it is in, so that its reader is chosen by what the study declares rather than by inspection:

input:
  DM:
    path: input/dm.csv

A listing kept in some other format is converted before the study reads it, and the converted file carries the name of what it now holds.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
source_profile_unknown
requirement
REQ-0852
expected/error.yaml
phase: validation
condition: source_profile_unknown
spec_paths:
  - input.DM.path
requirement: REQ-0852
context:
  dataset: DM
  path: input/dm.txt

Inputs

Under review
1 source file

input/dm.txt

Edit
STUDYID,USUBJID,SITEID
CTX,CTX-01,701
CTX,CTX-02,702

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITEIDStudy Site IdentifiercharacterCopy value from DM.SITEID.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml