Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: carry the age in AGE for each subject.
Input: collected demographics carrying age (AGE) for each
subject.
Variables:
AGEwould be the age, copied from the collected age field, but the copy asks for a field namedAGEYRS, which the collected demographics do not have, so the run is rejected before any data is read and no artifact is accepted.
How to fix
Decide which collected field holds the age, then name it exactly. When the source carries the age under its own name, copy that field:
- name: AGE
type: int
label: Age
derivation:
source: DM.AGE
When the source truly lacks the field, add it to the governed source first rather than pointing at a name nothing declares.
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- validation
- condition
- unknown_field
- requirement
- REQ-0103
expected/error.yaml
phase: validation
condition: unknown_field
spec_paths:
- columns.AGE.derivation.source
requirement: REQ-0103
context:
identifier: DM.AGEYRS
Inputs
Under review1 source fileinput/dm.csv
Edit2 rows| STUDYID | USUBJID | AGE |
|---|---|---|
| PILOT7 | 54 | |
| PILOT7 | 61 |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADSL | STUDYID | Study Identifier | character | Copy value from DM.STUDYID. | Predecessor | ||
| ADSL | USUBJID | Unique Subject Identifier | character | Copy value from DM.USUBJID. | Predecessor | ||
| ADSL | AGE | Age | numeric | Copy value from DM.AGEYRS. | Predecessor |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions