Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry the enrollment site (SITEID) for each subject.

Input: collected demographics listing carrying a site field (SITEID), whose records all end with a separator, which leaves the header's last field without a name.

Variables:

  • SITEID would be the site the subject enrolled at, copied from the collected listing.

The unnamed field can be asked for by no name, and readers disagree about whether the field is there at all: one reports three fields in every record and another four. The run is rejected and no artifact is accepted.

How to fix

Name every field the listing carries, or, when the listing has no further field, remove the trailing separator from the header and from every record. Removing it from the header alone leaves each record one field longer than the header, which is rejected too:

STUDYID,USUBJID,SITEID
CTX,CTX-01,701
CTX,CTX-02,702

A field worth storing is worth naming, and its name is what every later reference to it uses.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
ingest
condition
source_field_name_empty
requirement
REQ-0851
expected/error.yaml
phase: ingest
condition: source_field_name_empty
spec_paths:
  - input.DM.path
requirement: REQ-0851
context:
  dataset: DM
  path: input/dm.csv
  record: 1
  field: 4

Inputs

Under review
1 source file

input/dm.csv

Edit
raw CSV

Showing raw CSV because the source is not a valid rectangular table.

STUDYID,USUBJID,SITEID,
CTX,CTX-01,701,
CTX,CTX-02,702,

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITEIDStudy Site IdentifiercharacterCopy value from DM.SITEID.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml