Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build analysis records for laboratory tests carrying SEX, AVAL, and ANRHI, with the upper limit chosen for each test and sex.

Input: collected laboratory results carrying the collected result (LBSTRESN), test code (LBTESTCD), and sex (SEX), plus a reference table of upper limits by test code and sex.

Variables:

  • SEX would hold the sex the limit is chosen by, copied from the collected record.
  • AVAL would hold the collected result, copied from LBSTRESN.
  • ANRHI would hold the upper limit of normal for that test and sex, taken from the reference table for the matching test code and SEX; missing when no row matches or the sex is missing.

Note: the name the study reads for the reference table, input/lbref.csv, is a symbolic link: a stand-in that points at another file. Where it points can be changed without changing the study, so the limits that were reviewed and the limits that are read need not be the same. The run is rejected before any data is read and no artifact is accepted.

How to fix

Read the limits under the name that holds them:

input:
  LBREF:
    path: input/reference/lbref.csv

Storing the file itself where the study reads it works equally well. Either way one name reaches one file, and reviewing the study is reviewing what it reads.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
resource_path_symlink
requirement
REQ-0783
expected/error.yaml
phase: validation
condition: resource_path_symlink
spec_paths:
  - input.LBREF.path
requirement: REQ-0783
context:
  dataset: LBREF
  path: input/lbref.csv

Inputs

Under review
2 source files

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDSEXLBSTRESN
PILOT7ALTF42
PILOT7ALTM58

input/reference/lbref.csv

Edit
2 rows
input/reference/lbref.csv
LBTESTCDSEXANRHI
ALTF33
ALTM41

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBSEXSexcharacterCopy value from LB.SEX.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericTake ANRHI from the LBREF record whose LBTESTCD equals PARAMCD and SEX equals SEX, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml