Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: attempt one record per subject and laboratory test carrying the collected result in AVAL and the upper limit of normal for that test and the subject's sex in ANRHI.

Input: collected laboratory results carrying the collected result (LBSTRESN), test code (LBTESTCD), and sex (SEX), plus a reference table of upper limits by test code and sex.

Variables:

  • SEX would be the collected sex, taken from SEX in the collected records, and also chooses the limit.
  • AVAL would be the collected numeric result, taken from LBSTRESN.
  • ANRHI would be the upper limit of normal from the reference table for the record's test code and sex; missing when the table has no limit for that pair or the sex is missing.

Note: the reference table is named by a web address, https://reference.example.org/limits/lbref.csv, whose contents depend on when it is fetched and on who fetches it, so two runs of one study could read different limits while recording the same request. A run opens only stored files, never a web address, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Fetch the governed limits once, record which version was received, and store that copy with the study:

input:
  LBREF:
    path: input/lbref.csv

Retrieval belongs to the step that assembles study data, where the received version can be recorded and reviewed. It is not part of building the analysis dataset.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
resource_path_uri_scheme
requirement
REQ-0775
expected/error.yaml
phase: validation
condition: resource_path_uri_scheme
spec_paths:
  - input.LBREF.path
requirement: REQ-0775
context:
  dataset: LBREF
  path: https://reference.example.org/limits/lbref.csv

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDSEXLBSTRESN
PILOT7ALTF42
PILOT7ALTM58

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBSEXSexcharacterCopy value from LB.SEX.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericTake ANRHI from the LBREF record whose LBTESTCD equals PARAMCD and SEX equals SEX, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml