Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build one analysis row for each collected laboratory result, carrying SEX and AVAL through and adding ANRHI from a reference table of limits by test and sex.

Input: collected laboratory results carrying the collected result (LBSTRESN), test code (LBTESTCD), and sex (SEX), plus the reference table of upper limits by test code and sex.

Variables:

  • SEX would contain the subject's sex, carried from SEX in the laboratory results.
  • AVAL would contain the collected numeric result, carried from LBSTRESN.
  • ANRHI would be the upper limit of normal taken from the reference row whose test code matches the collected test code and whose sex matches the subject's sex; missing when no row matches or the sex is missing.

Note: the reference table is absent from the study, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide first whether the study should carry reference limits: add the approved table when the limits exist, and state an explicit policy only when the study genuinely has none.

Add the approved limit table to the study under the name it is read by, input/lbref.csv, with one row per test and sex:

LBTESTCD,SEX,ANRHI
ALT,F,33
ALT,M,41

If a study genuinely has no reference limits for a test, say so explicitly by supplying a result for the unmatched case rather than by leaving the table out. A file that is simply absent cannot be told apart from one that was forgotten.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
resource_path_missing
requirement
REQ-0785
expected/error.yaml
phase: validation
condition: resource_path_missing
spec_paths:
  - input.LBREF.path
requirement: REQ-0785
context:
  dataset: LBREF
  path: input/lbref.csv

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDSEXLBSTRESN
PILOT7ALTF42
PILOT7ALTM58

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBSEXSexcharacterCopy value from LB.SEX.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericTake ANRHI from the LBREF record whose LBTESTCD equals PARAMCD and SEX equals SEX, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml