Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: translate the collected overall response into its
analysis category (AVALC).
Input: response records carrying the collected overall
response (OVRLRESP).
Variables:
AVALCwould contain the analysis category matching the collected overall response:CRmeansCOMPLETE RESPONSE,PRmeansPARTIAL RESPONSE,SDmeansSTABLE DISEASE, andPDmeansPROGRESSIVE DISEASE. Every response must be present and listed; the collected valueNEis not, so the run is rejected with no artifact accepted.
How to fix
If NE is a valid collected response, add its governed analysis meaning to
the dictionary:
mapping:
source: RS.OVRLRESP
dict:
CR: COMPLETE RESPONSE
PR: PARTIAL RESPONSE
SD: STABLE DISEASE
PD: PROGRESSIVE DISEASE
NE: NOT EVALUABLE
If an unknown response should instead produce a missing result, state that
missing-value answer explicitly with unmapped: null. Prefer completing the
dictionary when the value is valid.
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- mapping
- condition
- unmapped_value
- requirement
- REQ-0334
expected/error.yaml
phase: mapping
condition: unmapped_value
spec_paths:
- columns.AVALC.derivation.mapping
requirement: REQ-0334
context:
source: RS.OVRLRESP
value: NE
keys:
- STUDYID: PILOT7
USUBJID: P7-702
RSSEQ: 1
Inputs
Under review1 source fileinput/rs.csv
Edit1 row| STUDYID | USUBJID | RSSEQ | OVRLRESP |
|---|---|---|---|
| PILOT7 | 1 | NE |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADRS | STUDYID | Study Identifier | character | Copy value from RS.STUDYID. | Predecessor | ||
| ADRS | USUBJID | Unique Subject Identifier | character | Copy value from RS.USUBJID. | Predecessor | ||
| ADRS | RSSEQ | Sequence Number | numeric | Copy value from RS.RSSEQ. | Predecessor | ||
| ADRS | AVALC | Analysis Value (C) | character | Recode RS.OVRLRESP: "CR" → "COMPLETE RESPONSE", "PR" → "PARTIAL RESPONSE", "SD" → "STABLE DISEASE", "PD" → "PROGRESSIVE DISEASE"; missing or unlisted values are errors. | Derived |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions