Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: carry sex and the collected result into the output and attach the upper limit of normal (ANRHI) chosen by test and sex.

Input: collected laboratory results carrying test code (LBTESTCD), sex (SEX), and numeric result (LBSTRESN), plus a reference table carrying test code, sex, and upper limit (ANRHI).

Variables:

  • ANRHI would be the upper limit of normal for that test and sex, read from the reference table where the collected test code and sex match a table entry. A collected test and sex with no table entry has no stated answer. Leaving the limit missing would hide that the result was never checked against a range, so the run is rejected with no artifact accepted.

How to fix

Add the governed AST/M reference range to the reference table when one exists. If the analysis intentionally leaves the limit missing when a complete key is not in the table, declare that missing-value answer:

intermediates:
  - id: LBREF_LOOKUP
    dataset: LBREF
    key: {LBTESTCD: PARAMCD, SEX: SEX}
    no_match: null

The same answer also covers a result whose test code or sex is blank: both find no entry (REQ-0129, REQ-0131).

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
join
condition
unmatched_key
requirement
REQ-0124
expected/error.yaml
phase: join
condition: unmatched_key
spec_paths:
  - intermediates[0]
requirement: REQ-0124
context:
  intermediate: LBREF_LOOKUP
  dataset: LBREF
  key:
    - LBTESTCD
    - SEX
  intermediate_key:
    LBTESTCD: AST
    SEX: M
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-842
      PARAMCD: AST

Inputs

Under review
2 source files

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDSEXLBSTRESN
PILOT7ALTF42
PILOT7ASTM55

input/lbref.csv

Edit
3 rows
input/lbref.csv
LBTESTCDSEXANRHI
ALTF33
ALTM41
ASTF32

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBSEXSexcharacterCopy value from LB.SEX.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericTake ANRHI from the LBREF record whose LBTESTCD equals PARAMCD and SEX equals SEX, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml