Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: record SEX for each subject, accepting only M, F, and U.

Input: collected demographics carrying subject sex (SEX).

Variables:

  • SEX would be the subject's sex, copied from the collected records, holding M, F, or U.

Note: the text pattern the codes are checked against names a group in a spelling ((?P<code>...)) that only some pattern readers accept, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide which codes the study collects, then write the check in the one notation every reader uses. A named group is spelled (?<name>...) rather than (?P<name>...), and a check that must describe the whole value anchors itself:

- matches:
    pattern: '^[MFU]$'

When the permitted set is small and fixed, list it instead. The list needs no text rule at all and cannot drift from the codes it names:

- allowed_values:
    values: [M, F, U]

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_regex
requirement
REQ-0827
expected/error.yaml
phase: validation
condition: invalid_regex
spec_paths:
  - columns.SEX.verifications[0].matches.pattern
requirement: REQ-0827
context:
  pattern: '(?P<code>[MFU])'

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDSEX
CATHM
CATHF

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSEXSexcharacterCopy value from DM.SEX.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml