Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build SMOKEFL from collected smoking status, matching without regard to case.

Input: collected demographics carrying reported smoking status (SMOKSTAT).

Variables:

  • SMOKEFL would be the smoking flag taken from SMOKSTAT without regard to case: Y gives Y, y gives Y, and N gives N. The entries for Y and y collide on the key Y once case is ignored, so the run is rejected before any data is read and no artifact is accepted.

How to fix

For case-insensitive matching, retain only one dictionary entry for each folded key. Both Y and y then resolve through Y:

mapping:
  source: DM.SMOKSTAT
  case_sensitive: false
  dict:
    Y: "Y"
    N: "N"

Alternatively, set case sensitivity on when differently cased values are intentionally distinct and give each one an explicit meaning.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
ambiguous_dictionary
requirement
REQ-0714
expected/error.yaml
phase: validation
condition: ambiguous_dictionary
spec_paths:
  - columns.SMOKEFL.derivation.mapping.dict
requirement: REQ-0714
context:
  folded_key: "Y"
  entries: ["Y", "y"]

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDSMOKSTAT
PILOT7Y
PILOT7y

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSMOKEFLSmoker FlagcharacterRecode DM.SMOKSTAT: "Y" → "Y", "y" → "Y", "N" → "N"; missing or unlisted values are errors; matching ignores letter case.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml