Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry sex and the numeric result into the output and choose the upper limit of normal (ANRHI) from a reference table by test and sex.

Input: collected laboratory records carrying test code (LBTESTCD), sex (SEX), and numeric result (LBSTRESN), plus a reference table carrying test code, sex, and upper limit (ANRHI).

Variables:

  • ANRHI would be the upper limit of normal for that test and sex, taken from the reference table row matching the collected test code and sex.

Note: a result whose test and sex match more than one line of the reference table has no single line to take its limit from. Taking either line, or the first the file happens to list, would make the result depend on file order rather than on the study's reference ranges, so the run is rejected with no artifact accepted, even when the lines agree.

How to fix

Make the lookup table unique on [LBTESTCD, SEX] by resolving the conflicting ALT/F reference limits under the study's governed reference-range rules. A lookup cannot choose one duplicate by file order.

If both rows are valid for different conditions, such as different assay methods, carry that condition on both the collected records and the table, and add it to the key, pairing the table column with the collected value. A collected field that is not an output column is named with its dataset prefix:

intermediates:
  - id: LBREF_LOOKUP
    dataset: LBREF
    key: {LBTESTCD: PARAMCD, SEX: SEX, METHOD: LB.METHOD}

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
join
condition
multiple_matches
requirement
REQ-0127
expected/error.yaml
phase: join
condition: multiple_matches
spec_paths:
  - intermediates[0]
requirement: REQ-0127
context:
  intermediate: LBREF_LOOKUP
  dataset: LBREF
  key:
    - LBTESTCD
    - SEX
  intermediate_key:
    LBTESTCD: ALT
    SEX: F
  match_count: 2
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-831
      PARAMCD: ALT

Inputs

Under review
2 source files

input/lb.csv

Edit
1 row
input/lb.csv
STUDYIDUSUBJIDLBTESTCDSEXLBSTRESN
PILOT7ALTF42

input/lbref.csv

Edit
3 rows
input/lbref.csv
LBTESTCDSEXANRHI
ALTF33
ALTF35
ALTM41

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBSEXSexcharacterCopy value from LB.SEX.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericTake ANRHI from the LBREF record whose LBTESTCD equals PARAMCD and SEX equals SEX, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml