Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: fill the analysis value (AVAL) of each planned vital-sign visit with the value collected there, or carry forward the latest earlier collected value for the same subject and parameter.

Input: planned vital-sign assessments, one record per subject, parameter, and planned visit number (AVISITN), each holding a collected value or a gap.

Variables:

  • AVAL would be the value collected at the visit when there is one, otherwise the latest earlier collected value for the same subject and parameter, and blank when no earlier value exists. Zero is a collected value, not a gap.

The input covers the cases that matter: a leading gap at visit 0, a trailing gap after the last collected value, a collected zero that must not be confused with a gap, and a parameter collected nowhere. But carrying a value forward needs an order that says which visits count as earlier, and the window names none, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Name the assessment order in the window, here the planned visit number:

locf:
  source: AVALCOL
  window:
    group_by: [USUBJID, PARAMCD]
    order_by: [AVISITN]

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
window_order_by_required
requirement
REQ-0340
expected/error.yaml
phase: validation
condition: window_order_by_required
spec_paths:
  - columns.AVAL.derivation.locf.window
requirement: REQ-0340
context:
  operation: locf

Inputs

Under review
1 source file

input/vs.csv

Edit
9 rows
input/vs.csv
USUBJIDPARAMCDAVISITNAVALCOL
SYSBP0—
SYSBP15
SYSBP2—
SYSBP3—
SYSBP46
SYSBP1—
SYSBP20
SYSBP3—
DIABP1—

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADVSUSUBJIDUnique Subject IdentifiercharacterCopy value from VS.USUBJID.Predecessor
ADVSPARAMCDParameter CodecharacterCopy value from VS.PARAMCD.Predecessor
ADVSAVISITNAnalysis Visit NumbernumericCopy value from VS.AVISITN.Predecessor
ADVSAVALAnalysis ValuenumericLast observation carried forward from AVALCOL within each group of USUBJID, PARAMCD.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml