Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry each collected laboratory result into AVAL and add its natural logarithm as AVALLN, with one record for each subject and parameter.

Input: five laboratory records across five subjects: a detectable viral load (12,000 copies/mL), an undetectable viral load reported as zero - the record the run rejects - a missing result, a low near-limit result (40), and a CD4 count (480), showing one record for each subject and parameter.

Variables:

  • AVAL would be the analysis value, mapped from the collected numeric result (LBSTRESN).
  • AVALLN would be the natural logarithm of AVAL, which the analysis models rather than the untransformed result, and blank when AVAL is blank. Zero has no logarithm, and a result below the limit of detection needs a stated substitution before it can be transformed, so the run fails while the values are computed and no artifact is accepted.

How to fix

State the analysis policy for an undetectable value. If it should produce a missing transformed result, guard zero explicitly:

derivation:
  compute:
    expr: "LN(NULLIF(AVAL, 0))"

If the study instead substitutes a value related to the assay limit, derive that stated substitute first and apply LN to it. Do not replace zero with an unstated constant.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
derivation
condition
ln_of_nonpositive
requirement
REQ-0432
expected/error.yaml
phase: derivation
condition: ln_of_nonpositive
spec_paths:
  - columns.AVALLN.derivation.compute
requirement: REQ-0432
context:
  expr: "LN(AVAL)"
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-762
      PARAMCD: HIVRNA

Inputs

Under review
1 source file

input/lb.csv

Edit
5 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDLBSTRESN
PILOT7HIVRNA12000
PILOT7HIVRNA0
PILOT7HIVRNA—
PILOT7HIVRNA40
PILOT7CD4480

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBAVALLNNatural Log of Analysis ValuenumericCompute LN(AVAL).Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml