Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: carry age into AGE and group subjects into AGEGRP,
with the older group holding elderly and the younger group
holding younger.
Input: collected demographics carrying age (AGE).
Variables:
AGEGRPwould containelderlyfor subjects aged 65 or older andyoungerfor everyone else, including a subject with no recorded age. The older group's fixed value is written as a structure instead of a single value, and no reader may guess which part names the group, so the run is rejected before any data is read and no artifact is accepted.
How to fix
Decide the exact text the group carries, then write that single value. When the older group reads as one word, state the word:
- when: "AGE >= 65"
then: {literal: elderly}
When the value genuinely has parts, each part needs its own result column rather than sharing one.
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- validation
- condition
- invalid_field_type
- requirement
- REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
- columns.AGEGRP.derivation.case[0].then.literal
requirement: REQ-0287
context:
expected: literal_value
actual: mapping
Inputs
Under review1 source fileinput/dm.csv
Edit4 rows| STUDYID | USUBJID | AGE |
|---|---|---|
| YAMAA-01 | 72 | |
| YAMAA-01 | 54 | |
| YAMAA-01 | 65 | |
| YAMAA-01 | — |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADSL | STUDYID | Study Identifier | character | Copy value from DM.STUDYID. | Predecessor | ||
| ADSL | USUBJID | Unique Subject Identifier | character | Copy value from DM.USUBJID. | Predecessor | ||
| ADSL | AGE | Age | numeric | Copy value from DM.AGE. | Predecessor | ||
| ADSL | AGEGRP | Age Group | character | If AGE >= 65 then "{'group': 'elderly'}"; otherwise "younger". | Derived |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions