Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: build ELDFL to mark each subject aged 65 or older with Y and every younger subject with N.

Input: collected demographics carrying numeric age (AGE), including one subject with no recorded age.

Variables:

  • AGE is the collected age, missing where it was not collected.
  • ELDFL would be Y for subjects aged 65 or older and N for younger subjects.

Note: the flag names N for a false condition but not what a subject with no recorded age receives, so the run is rejected before any data is read and no artifact is accepted.

How to fix

State what an unknown age returns. To give N to every subject not known to be 65 or older:

flag:
  condition: AGE >= 65
  false_value: N
  missing: N

Write missing: null instead to leave the flag missing when the age is unknown.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
missing_value_required
requirement
REQ-1258
expected/error.yaml
phase: validation
condition: missing_value_required
spec_paths:
  - columns.ELDFL.derivation.flag.missing
requirement: REQ-1258
context:
  false_value: "N"

Inputs

Under review
1 source file

input/dm.csv

Edit
3 rows
input/dm.csv
STUDYIDUSUBJIDAGESEX
YAMAA-0172M
YAMAA-0154F
YAMAA-01—F

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLAGEAgenumericCopy value from DM.AGE.Predecessor
ADSLELDFLElderly Flagcharacter"Y" when AGE >= 65; "N" otherwise; blank when the condition is unknown.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml