Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: build ELDFL to mark each subject aged 65 or older with Y,
leaving younger subjects missing.
Input: collected demographics carrying numeric age (AGE).
Variables:
AGEis the collected numeric age.ELDFLwould beYfor subjects aged 65 or older, missing otherwise.
Note: the flag's condition is written as the bare number 65 rather
than a test on age, so the run is rejected before any data is read and no
artifact is accepted.
How to fix
State the condition as a test on age:
flag: AGE >= 65
or name it inside the flag:
flag:
condition: AGE >= 65
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- validation
- condition
- invalid_field_type
- requirement
- REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
- columns.ELDFL.derivation.flag
requirement: REQ-0287
context:
expected: predicate
actual: int
Inputs
Under review1 source fileinput/dm.csv
Edit2 rows| STUDYID | USUBJID | AGE | SEX |
|---|---|---|---|
| YAMAA-01 | 72 | M | |
| YAMAA-01 | 54 | F |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADSL | STUDYID | Study Identifier | character | Copy value from DM.STUDYID. | Predecessor | ||
| ADSL | USUBJID | Unique Subject Identifier | character | Copy value from DM.USUBJID. | Predecessor | ||
| ADSL | ELDFL | Elderly Flag | character | "Y" when 65; blank otherwise. | Derived |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions