Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: build ELDFL to mark each subject aged 65 or older with Y, leaving younger subjects missing.

Input: collected demographics carrying numeric age (AGE).

Variables:

  • AGE is the collected numeric age.
  • ELDFL would be Y for subjects aged 65 or older, missing otherwise.

Note: the flag's condition is written as the bare number 65 rather than a test on age, so the run is rejected before any data is read and no artifact is accepted.

How to fix

State the condition as a test on age:

flag: AGE >= 65

or name it inside the flag:

flag:
  condition: AGE >= 65

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_field_type
requirement
REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
  - columns.ELDFL.derivation.flag
requirement: REQ-0287
context:
  expected: predicate
  actual: int

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDAGESEX
YAMAA-0172M
YAMAA-0154F

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLELDFLElderly Flagcharacter"Y" when 65; blank otherwise.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml