Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry COUNTRY on one record per subject, holding the subject's collected country in capitals, or the site country when the subject's own entry is blank.

Input: collected demographics records carrying the collected country (COUNTRY) and the site country (SITECNTY).

Variables:

  • COUNTRY would be the subject's own country in capitals, or the site country in capitals when the subject's own entry is blank.

Note: the uppercasing step is also asked to choose between the two entries, but it can only read one named value. Choosing the entry is a step of its own whose result must be named first, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Derive the selected source in a helper column, then pass that value to the uppercasing step:

- name: COUNTRYSRC
  type: str
  derivation:
    first_available:
      sources: [DM.COUNTRY, DM.SITECNTY]

- name: COUNTRY
  type: str
  derivation:
    str_case:
      source: COUNTRYSRC
      to: upper

Keep the helper column out of the artifact by leaving it off the artifact column list. A subject with both entries blank then stops the run; if that can happen, add missing: null beside source: COUNTRYSRC to leave that subject's country blank instead.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_field_type
requirement
REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
  - columns.COUNTRY.derivation.str_case.source
requirement: REQ-0287
context:
  expected: variable
  actual: mapping

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDCOUNTRYSITECNTY
PILOT7DeutschlandGermany
PILOT7—France

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLCOUNTRYCountrycharacterConvert {'first_available': {'sources': ['DM.COUNTRY', 'DM.SITECNTY']}} to upper case.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml