Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build the analysis dataset with one record per subject carrying SITEID.

Input: collected demographics records with SITEID giving the enrolling site.

Variables:

  • SITEID would hold the site the subject enrolled at, copied from the collected site.

Note: the completed dataset is checked for one record per site, but a site that enrolled more than one subject repeats its SITEID, which then cannot identify a subject record. The run is rejected and no artifact is accepted.

How to fix

Decide whether a record represents a subject or a site before editing anything. Assert uniqueness on the columns that truly identify a record. Either check the subject identifiers:

verifications:
  - unique:
      columns: [STUDYID, USUBJID]

or, when one record per site is the intent, aggregate the subjects to site records before asserting.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
verification
condition
unique_failed
requirement
REQ-0381
expected/error.yaml
phase: verification
condition: unique_failed
spec_paths:
  - verifications[0].unique
requirement: REQ-0381
context:
  columns: [SITEID]
  failure_count: 1
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-941
    - STUDYID: PILOT7
      USUBJID: P7-942

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDSITEID
PILOT7101
PILOT7101

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITEIDSite IdentifiercharacterCopy value from DM.SITEID.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml