Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: derive the site name (SITE) for analysis use, in lower case.

Input: collected demographics with study and subject identifiers and the numeric site number (SITENUM).

Variables:

  • SITE would be the site name in lower case, but it is taken from the site number (SITENUM), and a number has no lower-case form.

The request is rejected before any data is read, and no artifact is accepted.

How to fix

Fold the collected site name rather than its number, once SITENM is present in the demographics extract:

str_case:
  source: DM.SITENM
  to: lower

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
incompatible_input_type
requirement
REQ-0308
expected/error.yaml
phase: validation
condition: incompatible_input_type
spec_paths:
  - columns.SITE.derivation.str_case.source
requirement: REQ-0308
context:
  source: SITENUM
  expected: str
  actual: int

Inputs

Under review
1 source file

input/dm.csv

Edit
4 rows
input/dm.csv
STUDYIDUSUBJIDSITENUM
YAMAA-01101
YAMAA-01102
YAMAA-01999
YAMAA-011000

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITESite NamecharacterConvert SITENUM to lower case.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml