Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build analysis records for alanine aminotransferase (ALT), aspartate aminotransferase (AST), and their ratio (ASTALT), carrying ADT and AVAL for each subject, date, and parameter.

Input: collected results carrying the collection date, test code (either ALT or AST), and numeric result, plus a file of analysis values.

Variables:

  • ADT would be the date the result was collected.
  • AVAL would be the collected result on each transaminase record. On the ratio record it would be the aspartate value for the same subject and date, read from the dataset being built, divided by the alanine result; missing when either result is absent or the alanine result is zero.

The aspartate values the ratio reaches for are the values this run is producing under the same name. Nothing can distinguish the record being written from the record being read back, so the run is rejected before any data is read and no artifact is accepted.

How to fix

First decide whether the aspartate values the ratio reads are already final. If they are, they belong to a finished dataset that this run merely reads, so give that source a name of its own and keep the name of the dataset being built for the dataset being built:

input:
  LB: {path: input/lb.csv, types: {LBSTRESN: float}}
  ADLB_RAW: {path: input/adlb.csv, types: {AVAL: float, ADT: date}}

Renaming the declaration alone leaves the read pointing at a name that no longer exists, so change where it reads from as well:

intermediates:
  - id: ADLB_LOOKUP
    dataset: ADLB_RAW

The read then uses a completed dataset by its own name, which is an ordinary source like any other. If the aspartate values are not final, splitting the work applies instead: complete and write the transaminase parameters before the run that reads them starts.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
duplicate_identifier
requirement
REQ-0080
expected/error.yaml
phase: validation
condition: duplicate_identifier
spec_paths:
  - input.ADLB
  - domain
requirement: REQ-0080
context:
  identifier: ADLB

Inputs

Under review
2 source files

input/adlb.csv

Edit
4 rows
input/adlb.csv
STUDYIDUSUBJIDADTPARAMCDPARAMAVAL
PILOT72025-05-06ALTAlanine Aminotransferase40
PILOT72025-05-06ASTAspartate Aminotransferase60
PILOT72025-05-07ALTAlanine Aminotransferase25
PILOT72025-05-07ASTAspartate Aminotransferase20

input/lb.csv

Edit
4 rows
input/lb.csv
STUDYIDUSUBJIDLBSEQLBDTCLBTESTCDLBTESTLBSTRESN
PILOT712025-05-06ALTAlanine Aminotransferase40
PILOT722025-05-06ASTAspartate Aminotransferase60
PILOT712025-05-07ALTAlanine Aminotransferase25
PILOT722025-05-07ASTAspartate Aminotransferase20

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBADTAnalysis DatenumericISO 8601Copy value from LB.LBDTC.Predecessor
ADLBPARAMCDParameter CodecharacterALT, AST, ASTALTSet per constructed row; see the Row construction sheet.Derived
ADLBPARAMParametercharacterSet per constructed row; see the Row construction sheet.Derived
ADLBAVALAnalysis ValuenumericIf PARAMCD = 'ASTALT' then compute ASTVAL / NULLIF(ALTDEN, 0); otherwise "LBRESN".Derived
TemplateInclude whenPARAMCDPARAMLBRESNALTDEN
altLB.LBTESTCD = 'ALT'Constant "ALT"Constant "Alanine Aminotransferase"Copy LB.LBSTRESNConstant "None"
astLB.LBTESTCD = 'AST'Constant "AST"Constant "Aspartate Aminotransferase"Copy LB.LBSTRESNConstant "None"
ast_alt_ratioLB.LBTESTCD = 'ALT'Constant "ASTALT"Constant "Aspartate to Alanine Aminotransferase Ratio"Constant "None"Copy LB.LBSTRESN
VariablePermitted values
PARAMCDALT, AST, ASTALT
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml