As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: build analysis records for alanine aminotransferase
(ALT), aspartate aminotransferase (AST), and their ratio
(ASTALT), carrying ADT and AVAL for each subject, date, and
parameter.
Input: collected results carrying the collection date, test
code (either ALT or AST), and numeric result, plus a file of
analysis values.
Variables:
ADTwould be the date the result was collected.AVALwould be the collected result on each transaminase record. On the ratio record it would be the aspartate value for the same subject and date, read from the dataset being built, divided by the alanine result; missing when either result is absent or the alanine result is zero.
The aspartate values the ratio reaches for are the values this run is producing under the same name. Nothing can distinguish the record being written from the record being read back, so the run is rejected before any data is read and no artifact is accepted.
How to fix
First decide whether the aspartate values the ratio reads are already final. If they are, they belong to a finished dataset that this run merely reads, so give that source a name of its own and keep the name of the dataset being built for the dataset being built:
input:
LB: {path: input/lb.csv, types: {LBSTRESN: float}}
ADLB_RAW: {path: input/adlb.csv, types: {AVAL: float, ADT: date}}
Renaming the declaration alone leaves the read pointing at a name that no longer exists, so change where it reads from as well:
intermediates:
- id: ADLB_LOOKUP
dataset: ADLB_RAW
The read then uses a completed dataset by its own name, which is an ordinary source like any other. If the aspartate values are not final, splitting the work applies instead: complete and write the transaminase parameters before the run that reads them starts.
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- validation
- condition
- duplicate_identifier
- requirement
- REQ-0080
expected/error.yaml
phase: validation
condition: duplicate_identifier
spec_paths:
- input.ADLB
- domain
requirement: REQ-0080
context:
identifier: ADLB
Inputs
Under review2 source filesinput/adlb.csv
Edit4 rows| STUDYID | USUBJID | ADT | PARAMCD | PARAM | AVAL |
|---|---|---|---|---|---|
| PILOT7 | 2025-05-06 | ALT | Alanine Aminotransferase | 40 | |
| PILOT7 | 2025-05-06 | AST | Aspartate Aminotransferase | 60 | |
| PILOT7 | 2025-05-07 | ALT | Alanine Aminotransferase | 25 | |
| PILOT7 | 2025-05-07 | AST | Aspartate Aminotransferase | 20 |
input/lb.csv
Edit4 rows| STUDYID | USUBJID | LBSEQ | LBDTC | LBTESTCD | LBTEST | LBSTRESN |
|---|---|---|---|---|---|---|
| PILOT7 | 1 | 2025-05-06 | ALT | Alanine Aminotransferase | 40 | |
| PILOT7 | 2 | 2025-05-06 | AST | Aspartate Aminotransferase | 60 | |
| PILOT7 | 1 | 2025-05-07 | ALT | Alanine Aminotransferase | 25 | |
| PILOT7 | 2 | 2025-05-07 | AST | Aspartate Aminotransferase | 20 |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Comments and assessment materials
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADLB | STUDYID | Study Identifier | character | Copy value from LB.STUDYID. | Predecessor | ||
| ADLB | USUBJID | Unique Subject Identifier | character | Copy value from LB.USUBJID. | Predecessor | ||
| ADLB | ADT | Analysis Date | numeric | ISO 8601 | Copy value from LB.LBDTC. | Predecessor | |
| ADLB | PARAMCD | Parameter Code | character | ALT, AST, ASTALT | Set per constructed row; see the Row construction sheet. | Derived | |
| ADLB | PARAM | Parameter | character | Set per constructed row; see the Row construction sheet. | Derived | ||
| ADLB | AVAL | Analysis Value | numeric | If PARAMCD = 'ASTALT' then compute ASTVAL / NULLIF(ALTDEN, 0); otherwise "LBRESN". | Derived |
| Template | Include when | PARAMCD | PARAM | LBRESN | ALTDEN |
|---|---|---|---|---|---|
| alt | LB.LBTESTCD = 'ALT' | Constant "ALT" | Constant "Alanine Aminotransferase" | Copy LB.LBSTRESN | Constant "None" |
| ast | LB.LBTESTCD = 'AST' | Constant "AST" | Constant "Aspartate Aminotransferase" | Copy LB.LBSTRESN | Constant "None" |
| ast_alt_ratio | LB.LBTESTCD = 'ALT' | Constant "ASTALT" | Constant "Aspartate to Alanine Aminotransferase Ratio" | Constant "None" | Copy LB.LBSTRESN |
| Variable | Permitted values |
|---|---|
| PARAMCD | ALT, AST, ASTALT |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions