Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: carry AGE unchanged for analysis, keeping the collected
age for each subject.
Input: collected demographics records holding AGE.
Variables:
AGEwould contain the collected age copied from the collected records, but a stored age ofNAis not a number, so the run stops while reading the stored value and no artifact is accepted.
How to fix
Leave the field empty when an age was not collected, and keep reading the field as a number:
input:
DM:
path: input/dm.csv
types:
AGE: int
If the code carries a meaning worth keeping, such as an age withheld rather than never taken, read the field as text and map the code to a value the study defines.
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- ingest
- condition
- field_parse_failed
- requirement
- REQ-0536
expected/error.yaml
phase: ingest
condition: field_parse_failed
spec_paths:
- input.DM.types.AGE
requirement: REQ-0536
context:
dataset: DM
field: AGE
type: int
value: "NA"
Inputs
Under review1 source fileinput/dm.csv
Edit2 rows| STUDYID | USUBJID | AGE |
|---|---|---|
| CTX | 64 | |
| CTX | NA |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADSL | STUDYID | Study Identifier | character | Copy value from DM.STUDYID. | Predecessor | ||
| ADSL | USUBJID | Unique Subject Identifier | character | Copy value from DM.USUBJID. | Predecessor | ||
| ADSL | AGE | Age | numeric | Copy value from DM.AGE. | Predecessor |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions