Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: carry the age (AGE) for each subject the extract holds.

Input: EDC output in long form, one row per collected item; each subject has a sex row and an age row.

Variables:

  • AGE would be the age in whole years as collected. The collected rows it reads are also chosen by subject, under the name USUBJID, which those rows do not carry: they hold the subject as SubjectKey. The run is therefore rejected before any data is read, and no artifact is accepted.

How to fix

Decide what distinguishes the collected rows the age comes from, then say it in the words the records use. The collected rows carry the item they answer and the subject they belong to under the extract's own names:

- name: AGE
  type: int
  label: Age
  derivation:
    source:
      filter: ODM.ItemOID = 'IT.DM.AGE'
      variable: ODM.Value

The subject needs no mention: each record is built for one subject and reads only the rows that subject was collected under.

When the intent was to leave some subjects without an age, state that as a rule over the built record rather than over the collected rows, for example by mapping a collected exclusion flag.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
unknown_field
requirement
REQ-0132
expected/error.yaml
phase: validation
condition: unknown_field
spec_paths:
  - columns.AGE.derivation.source.filter
requirement: REQ-0132
context:
  identifier: USUBJID
  dataset: ODM

Inputs

Under review
1 source file

input/odm.csv

Edit
4 rows
input/odm.csv
StudyOIDMetaDataVersionOIDSubjectKeyStudyEventOIDStudyEventRepeatKeyItemGroupOIDItemGroupRepeatKeyItemOIDValue
STUDY01MDV.1001SCREENING1IG.DM1IT.DM.SEXMale
STUDY01MDV.1001SCREENING1IG.DM1IT.DM.AGE34
STUDY01MDV.1002SCREENING1IG.DM1IT.DM.SEXFemale
STUDY01MDV.1002SCREENING1IG.DM1IT.DM.AGE28

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
DOMAINDomain AbbreviationCharAssignedSet constant value "DM".SDTM1
STUDYIDStudy IdentifierCharCollectedCopy value from ODM.StudyOID.SDTM2
USUBJIDUnique Subject IdentifierCharCollectedCopy value from ODM.SubjectKey.SDTM3
AGEAgeNumCollectedCopy value from ODM.Value where ODM.ItemOID = 'IT.DM.AGE' AND USUBJID <> '002'.SDTM4
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml