Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry the site name (SITENM) onto a subject listing.

Input: collected demographics carrying SITENM.

Variables:

  • SITENM would be the name of the site the subject enrolled at, taken from the collected value.

One stored site name holds a byte written in an older encoding, which is not valid UTF-8 text. Replacing the byte with a substitute character would store a name the study never recorded, and dropping it would store a different name again, so the run is rejected while the file is read and no artifact is accepted.

How to fix

Export the listing as UTF-8, so every collected character keeps the value it was entered with. The second site name then stores its accented letter (o with circumflex, U+00F4) as the two bytes C3 B4 instead of the single byte F4 that the older encoding wrote.

Converting a file after the fact is safe only while the original encoding is known. A study that stores names in an unstated encoding cannot say which letters it collected.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
ingest
condition
invalid_text
requirement
REQ-0853
expected/error.yaml
phase: ingest
condition: invalid_text
spec_paths:
  - input.DM.path
requirement: REQ-0853
context:
  dataset: DM
  path: input/dm.csv
  record: 3
  field: 3

Inputs

Under review
1 source file

input/dm.csv

Edit
raw CSV

Showing raw CSV because the source is not a valid rectangular table.

Binary fixture; inspect it in the benchmark source.

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITENMStudy Site NamecharacterCopy value from DM.SITENM.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml