Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: number collected laboratory results within each subject, with VISITSEQ giving the collection sequence for each result.

Input: collected laboratory results carrying the numeric result (LBSTRESN) and the collection sequence.

Variables:

  • VISITSEQ would number each result within its subject in collection-sequence order, counting only the results a stated condition selects; the other results would keep their rows with a missing number. The condition arrives as a bare number (7) instead of a comparison, so which results it selects is undefined, and the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide which rows the study numbers, then state the rule as a comparison. When every collected result counts, leave the filter out entirely:

- name: VISITSEQ
  type: int
  derivation:
    row_number:
      window:
        group_by: [STUDYID, USUBJID]
        order_by: [LBSEQ]

When only some results count, write the condition they satisfy under window, for example filter: "LBSTRESN > 5.5", rather than numbering the rows by hand. The results it excludes keep their rows with a missing number.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_field_type
requirement
REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
  - columns.VISITSEQ.derivation.row_number.window.filter
requirement: REQ-0287
context:
  expected: predicate
  actual: int

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBSEQLBSTRESN
PILOT715.2
PILOT725.8

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBLBSEQSequence NumbernumericCopy value from LB.LBSEQ.Predecessor
ADLBLBSTRESNNumeric ResultnumericCopy value from LB.LBSTRESN.Predecessor
ADLBVISITSEQVisit SequencenumericRow number within each group of STUDYID, USUBJID, ordered by LBSEQ.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml