Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: derive ADT, AVAL, and PREVAL for collected weight measurements, where PREVAL holds the weight from the prior visit.

Input: collected weight records carrying a collection date (VSDTC) and a numeric weight (VSSTRESN).

Variables:

  • ADT would be the analysis date, carried over from the collected date.
  • AVAL would be the analysis weight, carried over from the collected numeric weight.
  • PREVAL would be the previous analysis weight, taken from the subject's prior record in date order, with ties broken by sequence number.

The request steps zero records along that order, so it asks for the record itself. A record's own weight is already the analysis weight, and a second name for it would let two spellings of one value drift apart, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Move to the preceding row with a negative step in the stated ascending visit order:

row_value:
  source: AVAL
  offset: -1
  window:
    group_by: [STUDYID, USUBJID]
    order_by: [ADT, VSSEQ]

The first row for each subject then stays missing because it has no preceding visit. If the current value is intended, use the analysis weight directly instead of a neighboring-row read.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
zero_offset
requirement
REQ-0328
expected/error.yaml
phase: validation
condition: zero_offset
spec_paths:
  - columns.PREVAL.derivation.row_value.offset
requirement: REQ-0328
context:
  offset: 0

Inputs

Under review
1 source file

input/vs.csv

Edit
2 rows
input/vs.csv
STUDYIDUSUBJIDVSSEQVSDTCVSSTRESN
PILOT712023-03-0172.4
PILOT722023-04-0171.8

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADVSSTUDYIDStudy IdentifiercharacterCopy value from VS.STUDYID.Predecessor
ADVSUSUBJIDUnique Subject IdentifiercharacterCopy value from VS.USUBJID.Predecessor
ADVSVSSEQSequence NumbernumericCopy value from VS.VSSEQ.Predecessor
ADVSADTAnalysis DatenumericISO 8601Copy value from VS.VSDTC.Predecessor
ADVSAVALAnalysis ValuenumericCopy value from VS.VSSTRESN.Predecessor
ADVSPREVALPrevious Analysis ValuenumericTake AVAL from the same row within each group of STUDYID, USUBJID, ordered by ADT then VSSEQ.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml