Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: derive REVIEWFL to mark adverse events (AEs) starting on or after 2025-01-01.

Input: collected adverse events carrying AESTDTC (event start date).

Variables:

  • REVIEWFL would be Y when the event start date is on or after 2025-01-01, and N otherwise, including when no start date was collected.

Note: the cutoff is written as text rather than as a calendar date, and a date cannot be compared with text, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Declare the constant as a date so both operands carry the same temporal type:

derivation:
  flag:
    condition: "ASTDT >= DATE '2025-01-01'"
    false_value: "N"
    missing: "N"

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
incompatible_input_type
requirement
REQ-0190
expected/error.yaml
phase: validation
condition: incompatible_input_type
spec_paths:
  - columns.REVIEWFL.derivation.flag.condition
requirement: REQ-0190
context:
  left_type: date
  right_type: str

Inputs

Under review
1 source file

input/ae.csv

Edit
1 row
input/ae.csv
STUDYIDUSUBJIDAESEQAESTDTC
PILOT712025-01-15

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEAESEQSequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEREVIEWFLProtocol Review Flagcharacter"Y" when ASTDT >= '2025-01-01'; "N" otherwise; "N" when the condition is unknown.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml