Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: give each analysis record the visit (AVISIT) of the one window whose first and last analysis days surround the record's analysis day (ADY).

Input: analysis records carrying the analysis day (ADY), and one study-wide window table giving each visit its first (AWLO) and last (AWHI) analysis day.

Variables:

  • ADY: the record's analysis day, carried through as given.
  • AVISIT would be the visit of the window whose first and last days, both included, surround the analysis day; missing when no window holds the day or the day is missing.

Note: a day that falls in two windows has no single visit, and choosing either would depend on a rule the study did not state, so the whole run fails and no dataset is produced.

How to fix

First correct unintended overlap in the window table, so that each analysis day falls in at most one window (here, end WEEK 2 on day 14). If overlap is intentional, state and justify a deterministic selection policy with order_by and keep on the window lookup; do not rely on source-row order. For example, to give a shared day to the window that starts later:

intermediates:
  - id: AWIN
    dataset: AWINDOW
    key: STUDYID
    between: {value: ADY, lower: AWLO, upper: AWHI}
    order_by: [AWINDOW.AWLO]
    keep: last

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
join
condition
multiple_matches
requirement
REQ-0127
expected/error.yaml
phase: join
condition: multiple_matches
spec_paths:
  - intermediates[0]
requirement: REQ-0127
context:
  intermediate: AWIN
  dataset: AWINDOW
  key:
    - STUDYID
  intermediate_key:
    STUDYID: CATH
  match_count: 2
  keys:
    - STUDYID: CATH
      USUBJID: CATH-UCSD-0099
      PARAMCD: SYSBP
      VSSEQ: 1

Inputs

Under review
2 source files

input/advs_raw.csv

Edit
1 row
input/advs_raw.csv
STUDYIDUSUBJIDPARAMCDVSSEQADY
CATHSYSBP115

input/awindow.csv

Edit
2 rows
input/awindow.csv
STUDYIDAVISITAWLOAWHI
CATHWEEK 2221
CATHWEEK 31528

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADVSSTUDYIDStudy IdentifiercharacterCopy value from ADVS_RAW.STUDYID.Predecessor
ADVSUSUBJIDUnique Subject IdentifiercharacterCopy value from ADVS_RAW.USUBJID.Predecessor
ADVSPARAMCDParameter CodecharacterCopy value from ADVS_RAW.PARAMCD.Predecessor
ADVSVSSEQSequence NumbernumericCopy value from ADVS_RAW.VSSEQ.Predecessor
ADVSADYAnalysis Relative DaynumericCopy value from ADVS_RAW.ADY.Predecessor
ADVSAVISITAnalysis VisitcharacterTake AVISIT from the AWINDOW record matching on STUDYID, where ADY falls within AWLO to AWHI, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml