Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: derive the measurement code (VSTESTCD) and the numeric result in standard units (VSSTRESN) for each collected vital-signs measurement, presented by subject and then by visit number.

Input: each input record is one collected vital-signs measurement carrying the measurement code (VSTESTCD), the numeric result (VSSTRESN), and the visit number (VISITNUM).

Variables:

  • VSTESTCD would name the measurement (for example SYSBP), taken from the collected code.
  • VSSTRESN would hold the numeric result in standard units, taken from the collected result.

Note: the requested order rests on the visit number, but no variable of the requested dataset carries it, so a completed record has no value to be ordered by. The run is rejected before any data is read and no artifact is accepted.

How to fix

Decide whether the visit number belongs in the dataset. When the order must rest on it, declare it as a variable and order by that variable; place it in the artifact columns only when the artifact should carry it:

output:
  path: vs.csv
  columns: [STUDYID, USUBJID, VSSEQ, VSTESTCD, VSSTRESN]
  order_by: [USUBJID, VISITNUM]

columns:
  # ... the existing columns, then:
  - name: VISITNUM
    type: float
    label: Visit Number
    derivation: VS_RAW.VISITNUM

An unplanned visit takes a sponsor-assigned decimal number (for example 2.01 after the planned visit it follows), which would fail int conversion, so the declared type is float.

When the visit number is not wanted at all, order by a variable the dataset already declares, such as the sequence number.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
undeclared_column
requirement
REQ-0224
expected/error.yaml
phase: validation
condition: undeclared_column
spec_paths:
  - output.order_by[1]
requirement: REQ-0224
context:
  column: VISITNUM

Inputs

Under review
1 source file

input/vs.csv

Edit
3 rows
input/vs.csv
STUDYIDUSUBJIDVSSEQVISITNUMVSTESTCDVSSTRESN
CATH11SYSBP128
CATH22SYSBP132
CATH11SYSBP119

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from VS_RAW.STUDYID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from VS_RAW.USUBJID.SDTM2
VSSEQSequence NumberNumCollectedCopy value from VS_RAW.VSSEQ.SDTM3
VSTESTCDVital Signs Test Short NameCharCollectedCopy value from VS_RAW.VSTESTCD.SDTM4
VSSTRESNNumeric Result/Finding in Standard UnitsNumCollectedCopy value from VS_RAW.VSSTRESN.SDTM5
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml