Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: arrange adverse event (AE) records so each subject's events read together, newest onset first, carrying the reported term (AETERM) and onset date (ASTDT).

Input: collected adverse event records carrying the reported term (AETERM) and the onset date (AESTDTC).

Variables:

  • AETERM would be the reported term for the event, carried over from the collected records.
  • ASTDT would be the date the event began, carried over from the collected onset date.

Note: the records are to be presented by subject ascending, then by onset date with the most recent first, then by subject descending again. The subject takes two places with opposite directions, and the second can never change the order the first already fixed, so the intended order is unclear. The run is rejected before any data is read and no artifact is accepted.

How to fix

Decide which position the subject holds and state it once. Grouping a subject's events together while reading the newest first is the subject ascending first and the date descending:

output:
  path: adae.csv
  columns: [STUDYID, USUBJID, ASEQ, AETERM, ASTDT]
  order_by:
    - USUBJID
    - variable: ASTDT
      direction: desc

Presenting the subjects in reverse instead means declaring the subject descending once, in the first position, rather than adding a second entry for it.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
duplicate_order_term
requirement
REQ-0224
expected/error.yaml
phase: validation
condition: duplicate_order_term
spec_paths:
  - output.order_by[2]
requirement: REQ-0224
context:
  column: USUBJID

Inputs

Under review
1 source file

input/ae.csv

Edit
3 rows
input/ae.csv
STUDYIDUSUBJIDAESEQAETERMAESTDTC
PILOT71Nausea2025-03-10
PILOT72Rash2025-03-12
PILOT71Headache2025-04-02

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEASEQAnalysis Sequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEAETERMReported Term for the Adverse EventcharacterCopy value from AE.AETERM.Predecessor
ADAEASTDTAnalysis Start DatenumericISO 8601Copy value from AE.AESTDTC.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml