Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: one record for each subject and collected parameter, carrying the numeric analysis result (AVAL).

Input: collected laboratory results carrying the test code (LBTESTCD) and the reported character result (LBSTRESC).

Variables:

  • AVAL would hold the reported number read from LBSTRESC for the collected parameter, and is missing when no result is reported. A result reported as a limit (such as <50) instead of a number cannot be read as the limit, as zero, or as missing without a stated rule, so the run fails and no artifact is accepted.

How to fix

Retain the reported text in a string column and state what the numeric analysis value should be. If a result such as <50 is intentionally represented as a missing numeric value, handle the failed conversion explicitly:

derivation:
  value:
    source: LB.LBSTRESC
  unconvertible: null

If the study uses a numeric substitution for values below the assay limit, derive that documented value instead and keep the original character result for traceability.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
convert
condition
conversion_failed
requirement
REQ-0013
expected/error.yaml
phase: convert
condition: conversion_failed
spec_paths:
  - columns.AVAL
requirement: REQ-0013
context:
  from: str
  to: float
  value: "<50"
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-942
      PARAMCD: HIVRNA

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDLBSTRESC
PILOT7HIVRNA12000
PILOT7HIVRNA<50

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESC.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml