Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: look up the sex-specific reference upper limit (LBSTNRHI) for each collected laboratory result by its test code and sex.

Input: collected results carrying the test code (LBTESTCD), sex (SEX), and numeric result (LBSTRESN), plus a limits table carrying the upper limit (NRHI) by test code and sex.

Variables:

  • LBSTNRHI would be the upper limit from the limits table for the matching test code and sex.

Note: a result with a blank sex has an incomplete lookup key and cannot find its sex-specific limit. Every result is required to find one, so such a result rejects the run with no artifact accepted.

How to fix

Recover the missing sex when possible. If an incomplete lookup key is intended to leave the upper limit missing, declare no_match: null; a result with a blank sex then gets a missing LBSTNRHI:

intermediates:
  - id: REFRANGE
    dataset: LBRANGE
    key: [LBTESTCD, SEX]
    no_match: null

An incomplete key and a complete key the table does not contain share one absence policy (REQ-0129, REQ-0131): both yield nothing, and no_match decides whether that fails or answers with a value.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
join
condition
unmatched_key
requirement
REQ-0124
expected/error.yaml
phase: join
condition: unmatched_key
spec_paths:
  - intermediates[0]
requirement: REQ-0124
context:
  intermediate: REFRANGE
  dataset: LBRANGE
  key:
    - LBTESTCD
    - SEX
  intermediate_key:
    LBTESTCD: ALT
    SEX:
  keys:
    - STUDYID: YAMAA-01
      USUBJID: YAMAA-01-102
      LBSEQ: 1

Inputs

Under review
2 source files

input/lb_raw.csv

Edit
4 rows
input/lb_raw.csv
STUDYIDUSUBJIDLBSEQLBTESTCDSEXLBSTRESN
YAMAA-011ALTF42
YAMAA-011ALT—38
YAMAA-011ALTM35
YAMAA-011ASTF28

input/lbrange.csv

Edit
3 rows
input/lbrange.csv
LBTESTCDSEXUNITNRLONRHI
ALTFU/L040
ALTMU/L040
ASTFU/L035

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from LB_RAW.STUDYID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from LB_RAW.USUBJID.SDTM2
LBSEQSequence NumberNumCollectedCopy value from LB_RAW.LBSEQ.SDTM3
LBTESTCDLab Test or Examination Short NameCharCollectedCopy value from LB_RAW.LBTESTCD.SDTM4
SEXSexCharCollectedCopy value from LB_RAW.SEX.SDTM5
LBSTNRHIReference Range Upper Limit-Std UnitsNumDerivedTake NRHI from the LBRANGE record matching on LBTESTCD and SEX, and a row with no match is an error.SDTM6
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml