Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: attach the reference-range upper limit (LBSTNRHI) to each collected result, carrying its test code and sex.

Input: collected results carrying test code (LBTESTCD), sex (SEX), and numeric result (LBSTRESN), plus a reference-limit table carrying the upper limit (NRHI) by test code and sex.

Variables:

  • LBSTNRHI would contain the upper limit value from the reference-limit table for the test code and sex of the result.

Note: the lookup names three limit-table columns, and each listed column matches the same-named current-row value. The collected results carry no unit, so the UNIT column would match against nothing. The unknown current-row value is rejected before any data is read; no artifact is accepted.

How to fix

If the limit table holds one unit per test code, match on test code and sex alone, since the collected results carry no unit:

intermediates:
  - id: REFRANGE
    dataset: LBRANGE
    key: [LBTESTCD, SEX]

When a current-row name differs from the table's, map the table column to it, as in key: {LBTESTCD: PARAMCD, SEX: SEX}.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
unknown_field
requirement
REQ-0117
expected/error.yaml
phase: validation
condition: unknown_field
spec_paths:
  - intermediates[0].key
requirement: REQ-0117
context:
  identifier: UNIT
  intermediate: REFRANGE

Inputs

Under review
2 source files

input/lb_raw.csv

Edit
2 rows
input/lb_raw.csv
STUDYIDUSUBJIDLBSEQLBTESTCDSEXLBSTRESN
YAMAA-011ALTF42
YAMAA-011ALTM35

input/lbrange.csv

Edit
2 rows
input/lbrange.csv
LBTESTCDSEXUNITNRLONRHI
ALTFU/L040
ALTMU/L040

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from LB_RAW.STUDYID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from LB_RAW.USUBJID.SDTM2
LBSEQSequence NumberNumCollectedCopy value from LB_RAW.LBSEQ.SDTM3
LBTESTCDLab Test or Examination Short NameCharCollectedCopy value from LB_RAW.LBTESTCD.SDTM4
SEXSexCharCollectedCopy value from LB_RAW.SEX.SDTM5
LBSTNRHIReference Range Upper Limit-Std UnitsNumDerivedTake NRHI from the LBRANGE record matching on LBTESTCD, SEX and UNIT, and a row with no match is an error.SDTM6
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml