Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: carry the source identifier through as ID and return
the project routine's result as RESULT.
Input: a source file with ID and VALUE, where VALUE
holds the numeric value passed to the routine.
Variables:
IDis the source identifier, carried through unchanged.RESULTwould be the numeric result of passing the sourceVALUEto theproject_valueroutine.
Note: the call omits the numeric input required by the routine. The run is rejected before any project code or data is read, and no artifact is accepted.
How to fix
Supply the required argument declared by the environment:
function:
name: project_value
args: {x: SOURCE.VALUE}
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- validation
- condition
- invalid_function_argument
- requirement
- REQ-0700
expected/error.yaml
phase: validation
condition: invalid_function_argument
spec_paths:
- columns.RESULT.derivation.function.args
requirement: REQ-0700
context:
function: project_value
argument: x
cause: missing_required_argument
Inputs
Under review1 source fileinput/source.csv
Edit1 row| ID | VALUE |
|---|---|
| 01 | 1.5 |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Variable Name | Variable Label | Type | Length | Controlled Terms or Format | Origin | Core | Conversion Definition | Variable Type | Variable Order | Comments for Define |
|---|---|---|---|---|---|---|---|---|---|---|
| ID | Identifier | Char | Collected | Copy value from SOURCE.ID. | SDTM | 1 | ||||
| RESULT | Project Function Result | Num | Derived | Call project function project_value. | SDTM | 2 |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions