Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry the collected analysis value in AVAL and add its doubled value in AVALDOUBLED, one record per collected result.

Input: collected laboratory (LB) results carrying the collected result in AVAL, identified by study and subject.

Variables:

  • AVAL would contain the collected result, taken from AVAL in the laboratory input; missing when the collected result is missing.
  • AVALDOUBLED would contain AVAL multiplied by 2; missing when the collected result is missing.

Note: the doubled value is listed before the collected value it reads, and a value may read only values listed before it, so the run is rejected before any data is read and no artifact is accepted.

How to fix

List AVAL before AVALDOUBLED, so every value reads only values already computed:

- name: AVAL
  type: float
  derivation: LB.AVAL
- name: AVALDOUBLED
  type: float
  derivation:
    compute:
      expr: "AVAL * 2"

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
forward_reference
requirement
REQ-0071
expected/error.yaml
phase: validation
condition: forward_reference
spec_paths:
  - columns.AVALDOUBLED.derivation.compute
requirement: REQ-0071
context:
  column: AVALDOUBLED
  dependency: AVAL

Inputs

Under review
1 source file

input/lb.csv

Edit
1 row
input/lb.csv
STUDYIDUSUBJIDAVAL
YAMAA-0110

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBAVALDOUBLEDDoubled Analysis ValuenumericCompute AVAL * 2.Derived
ADLBAVALAnalysis ValuenumericCopy value from LB.AVAL.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml