Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build a subject-level record carrying the moment treatment started in RFSTDTM and the calendar date of death in DTHDT and counting whole days between them in SURVDD.

Input: collected demographics carrying the treatment-start moment (RFSTDTC) and the death date (DTHDT).

Variables:

  • RFSTDTM would be the moment treatment started, time of day included, taken from RFSTDTC.
  • SURVDD would be the whole-day count from RFSTDTM to DTHDT.

Note: a day count has no meaning between a moment and a date: the hours on either side could give two different answers, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide which calendar days the study counts, then state them as dates. When only moments are collected, take each moment's calendar date first and count from it (start: RFSTD), so the count has whole days to count:

- name: RFSTD
  type: date
  derivation:
    to_date:
      source: RFSTDTM

When the hours matter, the study needs a finer unit than days, which this vocabulary does not offer; record that gap instead of rounding it away.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
incompatible_input_type
requirement
REQ-0606
expected/error.yaml
phase: validation
condition: incompatible_input_type
spec_paths:
  - columns.SURVDD.derivation.date_diff.start
requirement: REQ-0606
context:
  source: RFSTDTM
  expected: date
  actual: datetime

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDRFSTDTCDTHDT
YAMAA-012023-01-02T09:00:002023-05-14
YAMAA-012023-02-10T09:00:002023-06-01

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLRFSTDTMReference Start MomentnumericISO 8601Copy value from DM.RFSTDTC.Predecessor
ADSLDTHDTDate of DeathnumericISO 8601Copy value from DM.DTHDT.Predecessor
ADSLSURVDDSurvival Duration in DaysnumericWhole days from RFSTDTM to DTHDT, counting the end date but not the start.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml