Review ask
As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.
- Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
- Inputs: Do they trigger the failure for the reason the summary gives?
- Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?
The other tabs beside Comments are background for assessment, not under review.
Summary
README.mdGoal: one analysis row for each adverse event carrying the
analysis start (ASTDT) and a second analysis start (ASTDT2).
Input: collected adverse event records carrying the reported
start (AESTDTC).
Variables:
ASTDTwould contain the analysis start date taken from the reported start.ASTDT2would be the calendar date taken from the analysis start, but taking a calendar date needs a date-time value or date text while the analysis start is already a date, so the run is rejected before any data is read and no artifact is accepted.
How to fix
Use the date directly (derivation: ASTDT). When the source is a datetime,
extract its calendar date explicitly:
- name: ASTDT2
type: date
derivation:
to_date: {source: ASTDTM}
Expected failure
Editthe run is rejected; no artifact is acceptedexpected/error.yaml- phase
- validation
- condition
- incompatible_input_type
- requirement
- REQ-0607
expected/error.yaml
phase: validation
condition: incompatible_input_type
spec_paths:
- columns.ASTDT2.derivation.to_date.source
requirement: REQ-0607
context:
source: ASTDT
expected: datetime, ISO date text, or ISO 8601 datetime text
actual: date
Inputs
Under review1 source fileinput/ae.csv
Edit1 row| STUDYID | USUBJID | AESEQ | AESTDTC |
|---|---|---|---|
| YAMAA-01 | 1 | 2025-01-15 |
Unexpected Output
Under reviewNo artifact is producedNo fixture files in this directory.
Shaded columns are derived— = missing value
Comments and assessment materials
Not under review
| Dataset Name | Variable Name | Variable Label | Type | Codelist/Controlled Terms | Core | Computational Method | Origin |
|---|---|---|---|---|---|---|---|
| ADAE | STUDYID | Study Identifier | character | Copy value from AE.STUDYID. | Predecessor | ||
| ADAE | USUBJID | Unique Subject Identifier | character | Copy value from AE.USUBJID. | Predecessor | ||
| ADAE | AESEQ | Sequence Number | numeric | Copy value from AE.AESEQ. | Predecessor | ||
| ADAE | ASTDT | Analysis Start Date | numeric | ISO 8601 | Copy value from AE.AESTDTC. | Predecessor | |
| ADAE | ASTDT2 | Analysis Start Date from Datetime | numeric | ISO 8601 | Take the date part of ASTDT. | Derived |
| Version | Date | Author | Description | Reviewer | Sign-off |
|---|---|---|---|---|---|
| 1.3 | 2026-09-29 | yamaa docs build | Show study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata | ||
| 1.2 | 2026-09-29 | yamaa docs build | Classify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived | ||
| 1.1 | 2026-09-29 | yamaa docs build | Resolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML | ||
| 1.0 | yamaa docs build | Initial generation from spec.yaml |
yamaa
Comments
Signed in with GitHub; saved in repository Discussions