Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Would a real study need this derivation, specified this way? Does it follow CDISC ADaM: variable names, controlled terms, record structure? Flag any rule that is ambiguous or that a sponsor would handle differently.
  2. Inputs: Do they look like data collected in a real trial, and do they include the situations you would expect to meet in one?
  3. Expected output: Would independent QC programming reproduce every value from these inputs and rules?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: bound the rows a filter matches, by count and by share: upper and lower count bounds, upper and lower share bounds, per-group share bounds with an inclusive edge, and a deliberately violated warning.

Input: eight subjects in two arms of four. Each has an ARM, a FLAG marking it for review, and a collected VAL. Three are flagged (one in arm A, two in arm B); seven carry a value and one does not.

Checks:

  • Flagged subjects stay at or under one half: 3 of 8 do, so the check holds.
  • Subjects with a collected value stay above three quarters: 7 of 8 do, so the check holds.
  • Per arm, flagged subjects stay at or under one half: arm A has 1 of 4, arm B has 2 of 4, and the exact half counts as held.
  • Flagged subjects number at most three: exactly 3 do, so the check holds and pins the inclusive count boundary.
  • Subjects with a collected value number at least seven: exactly 7 do, so the check holds and pins the inclusive count boundary.
  • Unflagged subjects stay at or under one half: 5 of 8 do not, so the check is violated. It is a warning, so the run still succeeds and the warning log carries the broken check.

The check log records REPORT_VERSION, ARTIFACT, SPEC_PATH, VERIFICATION_ID, CHECK, TARGET, REQUIREMENT, SEVERITY, OUTCOME, CONDITION, EVALUATED_COUNT, FAILURE_COUNT, and DETAILS. The group check evaluates two groups; the others evaluate the whole dataset as one unit. A held check leaves CONDITION empty and reports zero failures; the violated warning names its condition and reports how many rows matched out of how many.

The warning log records LOG_VERSION, ARTIFACT, SEVERITY, CONDITION, REQUIREMENT, SPEC_PATH, VERIFICATION_ID, FAILURE_COUNT, OFFENDING_KEYS, and DETAILS. A dataset-level check has no offending rows, so it carries an empty key set.

Inputs

Under review
1 source file

input/dm.csv

Edit
8 rows
input/dm.csv
USUBJIDARMFLAGVAL
AY12
AN10
AN—
AN9
BY11
BY8
BN7
BN6

Expected output

Under review
15 expected rows

expected/adsl-checks.csv

Edit
6 rows
expected/adsl-checks.csv
REPORT_VERSIONARTIFACTSPEC_PATHVERIFICATION_IDCHECKTARGETREQUIREMENTSEVERITYOUTCOMECONDITIONEVALUATED_COUNTFAILURE_COUNTDETAILS
1.0adsl.csvverifications[0].row_countflagged-share-within-limitrow_count—REQ-0385errorheld—10{}
1.0adsl.csvverifications[1].row_countvalues-mostly-presentrow_count—REQ-0385errorheld—10{}
1.0adsl.csvverifications[2].row_countflagged-share-by-armrow_count—REQ-0385errorheld—20{}
1.0adsl.csvverifications[3].row_countflagged-count-within-limitrow_count—REQ-0385errorheld—10{}
1.0adsl.csvverifications[4].row_countvalues-count-floorrow_count—REQ-0385errorheld—10{}
1.0adsl.csvverifications[5].row_countunflagged-share-warningrow_count—REQ-0385warningviolatedrow_count_failed11{"count":5,"denominator":8}

expected/adsl-warnings.csv

Edit
1 row
expected/adsl-warnings.csv
LOG_VERSIONARTIFACTSEVERITYCONDITIONREQUIREMENTSPEC_PATHVERIFICATION_IDFAILURE_COUNTOFFENDING_KEYSDETAILS
1.0adsl.csvwarningrow_count_failedREQ-0385verifications[5].row_countunflagged-share-warning1[{}]{"count":5,"denominator":8}

expected/adsl.csv

Edit
8 rows
expected/adsl.csv
USUBJIDARMFLAGVAL
AY12
AN10
AN—
AN9
BY11
BY8
BN7
BN6
Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLARMPlanned ArmcharacterCopy value from DM.ARM.Predecessor
ADSLFLAGFlagged for ReviewcharacterCopy value from DM.FLAG.Predecessor
ADSLVALCollected ValuenumericCopy value from DM.VAL.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml

yamaa code

Runs the yamaa specification; its result must match the expected output

run.R

Edit
4 lines
library(yamaa)adsl <- yamaa_domain("spec.yaml")$outputadsl

run.py

Edit
4 lines
import yamaaadsl = yamaa.yamaa_domain("spec.yaml").outputadsl