Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: work out PCHG, the percent change from baseline, from the collected result in AVAL and its baseline in BASE.

Input: laboratory results with baseline values from LB, carrying the collected numeric result (LBSTRESN) and the baseline it is compared with (LBBLRESN).

Variables:

  • AVAL would be the collected numeric result, taken from LBSTRESN.
  • BASE would be the baseline it is compared with, taken from LBBLRESN.
  • PCHG would be the change from baseline as a percentage of it, worked out as 100 * (AVAL - BASE) / BASE; missing when either value is missing.

Note: a zero baseline leaves the percentage with no value. Leaving it missing would assume a rule the request never stated, so the run fails and no artifact is accepted.

How to fix

If the intended result is missing when BASE is zero, guard the denominator explicitly with NULLIF:

derivation:
  compute:
    expr: "100 * (AVAL - BASE) / NULLIF(BASE, 0)"

NULLIF(BASE, 0) returns missing for a zero baseline. Missing then propagates through the division, so PCHG is missing for that row instead of raising division_by_zero; nonzero baselines retain the original calculation.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
derivation
condition
division_by_zero
requirement
REQ-0430
expected/error.yaml
phase: derivation
condition: division_by_zero
spec_paths:
  - columns.PCHG.derivation.compute
requirement: REQ-0430
context:
  expr: "100 * (AVAL - BASE) / BASE"
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-742
      PARAMCD: ALT

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDLBSTRESNLBBLRESN
PILOT7ALT4235
PILOT7ALT380

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBBASEBaseline ValuenumericCopy value from LB.LBBLRESN.Predecessor
ADLBPCHGPercent Change from BaselinenumericCompute 100 * (AVAL - BASE) / BASE.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml