Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: mark the baseline record of each subject and parameter with ABLFL and repeat its value with BASE.

Input: collected laboratory results with test code, collection date, and numeric result (LBTESTCD, LBDTC, LBSTRESN), plus subject treatment start dates from ADSL (TRTSDT).

Variables:

  • ADT would contain the collection date, taken from LBDTC.
  • TRTSDT would contain the subject's treatment start date, taken from ADSL TRTSDT.
  • AVAL would contain the analysis value, taken from LBSTRESN.
  • ABLFL would be Y on the baseline record for the subject and parameter: the latest result on or before treatment start, and blank on every other record.
  • BASE would contain the baseline record's AVAL on every record for the subject and parameter; missing when no result falls on or before treatment start.

Note: results sharing one collection date can tie for latest, and either candidate gives the parameter a different baseline. The run fails and no dataset is accepted.

How to fix

Decide which of the two draws is the baseline before choosing how to state it. Two results drawn on the same day are usually a sample and its repeat, and the source data system should carry the result the study reports, or a collection time that separates the draws. Correcting it there leaves the rule saying what it means: the latest result on or before treatment start.

When both draws are reportable and the study states a tie-break, choose the record explicitly instead of by date alone. Order the eligible results and mark the first:

- name: ABLRANK
  type: int
  derivation:
    row_number:
      window:
        group_by: [STUDYID, USUBJID, PARAMCD]
        order_by:
          - {variable: ADT, direction: desc}
          - {variable: LBSEQ, direction: desc}
        filter: "ADT <= TRTSDT"

- name: ABLFL
  type: str
  derivation:
    flag: "ABLRANK = 1"

Keep ABLRANK internal by omitting it from output.columns.

Order by the term the study names; the sequence number above stands in for it and is not itself a clinical rule. Do not average the two results into one baseline value, which reports a measurement nobody took.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
derivation
condition
ambiguous_baseline
requirement
REQ-0322
expected/error.yaml
phase: derivation
condition: ambiguous_baseline
spec_paths:
  - columns.ABLFL.derivation.baseline_flag
requirement: REQ-0322
context:
  date: "2025-01-06"
  match_count: 2
  keys:
    - STUDYID: CATH
      USUBJID: CATH-UCSD-0001
      PARAMCD: ALT

Inputs

Under review
2 source files

input/adsl.csv

Edit
2 rows
input/adsl.csv
STUDYIDUSUBJIDTRTSDT
CATH2025-01-07
CATH2025-01-07

input/lb.csv

Edit
5 rows
input/lb.csv
STUDYIDUSUBJIDLBSEQLBTESTCDLBDTCLBSTRESN
CATH1ALT2025-01-0622
CATH2ALT2025-01-0631
CATH3ALT2025-01-2026
CATH1ALT2025-01-0518
CATH2ALT2025-01-1924

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBLBSEQSequence NumbernumericCopy value from LB.LBSEQ.Predecessor
ADLBADTAnalysis DatenumericISO 8601Copy value from LB.LBDTC.Predecessor
ADLBTRTSDTDate of First Exposure to TreatmentnumericISO 8601Copy value from ADSL.TRTSDT.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBABLFLBaseline Record Flagcharacter"Y" for the last record with ADT on or before TRTSDT within each group of STUDYID, USUBJID, PARAMCD; blank otherwise.Derived
ADLBBASEBaseline ValuenumericAggregate ONLY(AVAL) over records grouped by STUDYID, USUBJID, PARAMCD, matching on the shared output keys, where ABLFL = 'Y'.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml