Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build one record per subject carrying RFSTD, DTHDTM, and DTHDY.

Input: collected demographics rows carrying the treatment-start date (RFSTDT) and the collected moment of death (DTHDTC).

Variables:

  • RFSTD would hold the treatment-start date copied from the collected date.
  • DTHDTM would hold the moment of death, time of day included, copied from the collected moment, and would be blank when no death is recorded.
  • DTHDY would hold the study day of death, with the treatment-start date as day 1 and no day zero, and would be blank when no death is recorded.

A study day counts calendar dates, and a moment is not one: widening the moment into a date would choose silently between two adjacent days, so no reader may do so. The request is rejected before any data is read, and no artifact is accepted.

How to fix

Decide which calendar day the study reports, then state it as a date. When only the moment is collected, take its calendar date first and count the study day from that date:

- name: DTHDT
  type: date
  label: Date of Death
  derivation:
    to_date:
      source: DTHDTM

- name: DTHDY
  type: int
  label: Study Day of Death
  derivation:
    study_day:
      date: DTHDT
      reference: RFSTD

When the time of day carries meaning, a day count is the wrong result; keep the moment instead of forcing it into one.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
incompatible_input_type
requirement
REQ-0606
expected/error.yaml
phase: validation
condition: incompatible_input_type
spec_paths:
  - columns.DTHDY.derivation.study_day.date
requirement: REQ-0606
context:
  source: DTHDTM
  expected: date
  actual: datetime

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDRFSTDTDTHDTC
PILOT72023-01-022023-05-14T18:30:00
PILOT72023-02-10—

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLRFSTDReference Start DatenumericISO 8601Copy value from DM.RFSTDT.Predecessor
ADSLDTHDTMMoment of DeathnumericISO 8601Copy value from DM.DTHDTC.Predecessor
ADSLDTHDYStudy Day of DeathnumericCDISC study day of DTHDTM against RFSTD as day 1; there is no day zero.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml