Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: read SITEID out of the subject identifier for each subject record.

Input: collected demographics with one record for each subject, carrying the subject identifier.

Variables:

  • SITEID would hold the site code, the text between CATH- and the four-digit subject number in an identifier matching ^CATH-([^-]+)-[0-9]{4}$, and would be blank when the subject identifier is blank or does not fit that form.

The request asks for a second part of that match, but the match sets aside only one, the site code. The request is rejected before any data is read, and no artifact is accepted.

How to fix

Decide which part of the subject identifier names the site, then take the part the rule actually sets aside. Parts are numbered from 1 in the order their opening parentheses appear, so the site here is part 1:

str_extract:
  source: USUBJID
  pattern: '^CATH-([^-]+)-[0-9]{4}$'
  group: 1
  missing: null
  no_match: null

Setting aside the subject number as well does not move the site: its opening parenthesis still comes first, so the site stays part 1 and the subject number is part 2:

str_extract:
  source: USUBJID
  pattern: '^CATH-([^-]+)-([0-9]{4})$'
  group: 1
  missing: null
  no_match: null

Keep the blank results for a blank or ill-formed identifier; dropping them would stop the run on such an identifier instead.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
regex_group_out_of_range
requirement
REQ-0816
expected/error.yaml
phase: validation
condition: regex_group_out_of_range
spec_paths:
  - columns.SITEID.derivation.str_extract.group
requirement: REQ-0816
context:
  group: 2
  group_count: 1
  pattern: '^CATH-([^-]+)-[0-9]{4}$'

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJID
CATH
CATH

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITEIDStudy Site IdentifiercharacterExtract capture group 2 matching ^CATH-([^-]+)-[0-9]{4}$ from USUBJID; a missing source → blank; no match → blank.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml