Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: carry the planned arm (ARM) and the actual arm (ACTARM) for each subject.

Input: EDC output in long form, one row per collected item.

Variables:

  • ARM would be the planned arm as collected; Unassigned when none was collected.
  • ACTARM would be the actual arm, a copy of the planned arm, but the copy also states which collected rows to choose among. The planned arm is one value by then rather than a set of rows, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide whether the actual arm repeats a value the record already carries or reads the collected rows itself. Repeating the planned arm names it and nothing else:

- name: ACTARM
  type: str
  label: Description of Actual Arm
  derivation:
    source: ARM

When the actual arm is collected in its own right, read the rows that hold it, exactly as the planned arm does:

- name: ACTARM
  type: str
  label: Description of Actual Arm
  derivation:
    first_available:
      sources:
        - filter: ODM.ItemOID = 'IT.DM.ACTARM'
          variable: ODM.Value
      missing: Unassigned

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
prohibited_construct
requirement
REQ-0148
expected/error.yaml
phase: validation
condition: prohibited_construct
spec_paths:
  - columns.ACTARM.derivation.source.filter
requirement: REQ-0148
context:
  identifier: ARM

Inputs

Under review
1 source file

input/odm.csv

Edit
4 rows
input/odm.csv
StudyOIDMetaDataVersionOIDSubjectKeyStudyEventOIDStudyEventRepeatKeyItemGroupOIDItemGroupRepeatKeyItemOIDValue
STUDY01MDV.1001SCREENING1IG.DM1IT.DM.SEXMale
STUDY01MDV.1001SCREENING1IG.DM1IT.DM.AGE34
STUDY01MDV.1002SCREENING1IG.DM1IT.DM.SEXFemale
STUDY01MDV.1002SCREENING1IG.DM1IT.DM.AGE28

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
DOMAINDomain AbbreviationCharAssignedSet constant value "DM".SDTM1
STUDYIDStudy IdentifierCharCollectedCopy value from ODM.StudyOID.SDTM2
USUBJIDUnique Subject IdentifierCharCollectedCopy value from ODM.SubjectKey.SDTM3
ARMDescription of Planned ArmCharDerivedFirst non-missing of ODM.Value where ODM.ItemOID = 'IT.DM.ARM'; all missing → "Unassigned".SDTM4
ACTARMDescription of Actual ArmCharDerivedCopy value from ARM where ODM.ItemOID = 'IT.DM.ARM'.SDTM5
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml