Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build a subject-level listing carrying SITEID and SEX.

Input: collected demographics records for two subjects at one site, carrying SITEID and two fields both named SEX. The two fields agree for the first subject and disagree for the second, so no single answer is defensible there.

Variables:

  • SITEID would contain the site the subject enrolled at, copied from the collected records.
  • SEX would contain the recorded sex, copied from the collected records, but a value asked for by that name could come from either of the two fields, which disagree for the second subject.

The run is rejected when the listing is read and no artifact is accepted.

How to fix

Give every field of the listing its own name. If the second field holds the sex as it was first collected, name it for that, and read whichever one the study governs:

STUDYID,USUBJID,SITEID,SEX,SEXORIG

If the two fields hold the same fact twice, remove one at the source. A listing that answers to one name twice cannot be read the same way twice.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
ingest
condition
source_field_name_duplicate
requirement
REQ-0851
expected/error.yaml
phase: ingest
condition: source_field_name_duplicate
spec_paths:
  - input.DM.path
requirement: REQ-0851
context:
  dataset: DM
  path: input/dm.csv
  record: 1
  field: SEX

Inputs

Under review
1 source file

input/dm.csv

Edit
raw CSV

Showing raw CSV because the source is not a valid rectangular table.

STUDYID,USUBJID,SITEID,SEX,SEX
YAMAA-01,YAMAA-01-101,101,F,F
YAMAA-01,YAMAA-01-102,101,M,F

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLSITEIDStudy Site IdentifiercharacterCopy value from DM.SITEID.Predecessor
ADSLSEXSexcharacterCopy value from DM.SEX.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml