Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build one record per subject carrying the actual treatment for period 01 (TRT01A).

Input: demographics records plus analysis-subject records carrying a treatment (TRT01A).

Variables:

  • TRT01A would contain the treatment from the analysis-subject record for the same subject.

When more than one analysis-subject record shares one subject's identifiers, nothing says which treatment applies. Taking either one would report a treatment the study data does not single out, so the run is rejected with no artifact accepted.

How to fix

Reconcile the analysis-subject source so each subject has one supported treatment. If multiple records are legitimate, add a field that expresses the choice, such as an effective timestamp, and select by it explicitly:

intermediates:
  - id: ADSL_LOOKUP
    dataset: ADSL_RAW
    order_by: [ADSL_RAW.EFFECTIVEDTC]
    keep: last

Do not use file order or treatment text as a substitute for a study rule.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
join
condition
multiple_matches
requirement
REQ-0127
expected/error.yaml
phase: join
condition: multiple_matches
spec_paths:
  - columns.TRT01A.derivation.source
requirement: REQ-0127
context:
  intermediate: intermediate(ADSL_RAW)
  dataset: ADSL_RAW
  key:
    - STUDYID
    - USUBJID
  intermediate_key:
    STUDYID: PILOT7
    USUBJID: P7-701
  match_count: 2
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-701

Inputs

Under review
2 source files

input/adsl_raw.csv

Edit
2 rows
input/adsl_raw.csv
STUDYIDUSUBJIDTRT01A
PILOT7Pembrolizumab
PILOT7Placebo

input/dm.csv

Edit
1 row
input/dm.csv
STUDYIDUSUBJID
PILOT7

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLTRT01AActual Treatment for Period 01characterCopy value from ADSL_RAW.TRT01A.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml