Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: fill a missing weight from the most recent earlier weight, carrying ADT, AVAL, and AVALF for each measurement.

Input: collected weight records carrying the collection date (VSDTC), the test code (VSTESTCD), and the collected result (VSSTRESN).

Variables:

  • ADT would be the analysis date taken from the collection date.
  • AVAL would be the collected weight taken from the collected result, and missing when no measurement was taken.
  • AVALF would be the current weight or, when it is missing, the filled weight of the previous measurement in date order. After two gaps in a row, the second would read a weight that was itself filled in, so the filled weight is stated in terms of itself.

Note: filling one gap and stopping, or resolving the records in an order nothing states, would each give a different answer from the same data, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Carry from the collected series rather than from the filled output. Search the earlier collected values, then take the first available of AVAL and PRIOR:

- name: PRIOR
  type: float
  derivation:
    previous_non_missing:
      source: AVAL
      window:
        group_by: [STUDYID, USUBJID, PARAMCD]
        order_by: [ADT, VSSEQ]

- name: AVALF
  type: float
  derivation:
    first_available:
      sources: [AVAL, PRIOR]

Keep PRIOR internal by omitting it from output.columns.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
dependency_cycle
requirement
REQ-0072
expected/error.yaml
phase: validation
condition: dependency_cycle
spec_paths:
  - columns.AVALF.derivation.first_available
  - columns.PRIORF.derivation.row_value
requirement: REQ-0072
context:
  cycle: [AVALF, PRIORF, AVALF]

Inputs

Under review
1 source file

input/vs.csv

Edit
4 rows
input/vs.csv
STUDYIDUSUBJIDVSSEQVSDTCVSTESTCDVSSTRESN
PILOT712025-01-05WEIGHT70.5
PILOT722025-02-05WEIGHT—
PILOT732025-03-05WEIGHT—
PILOT742025-04-05WEIGHT72.0

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADVSSTUDYIDStudy IdentifiercharacterCopy value from VS.STUDYID.Predecessor
ADVSUSUBJIDUnique Subject IdentifiercharacterCopy value from VS.USUBJID.Predecessor
ADVSVSSEQSequence NumbernumericCopy value from VS.VSSEQ.Predecessor
ADVSPARAMCDParameter CodecharacterCopy value from VS.VSTESTCD.Predecessor
ADVSADTAnalysis DatenumericISO 8601Copy value from VS.VSDTC.Predecessor
ADVSAVALAnalysis ValuenumericCopy value from VS.VSSTRESN.Predecessor
ADVSAVALFFilled Analysis ValuenumericFirst non-missing of AVAL and PRIORF.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml