Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: attempt the total of each subject's collected results (AVALTOT), written as the row formula SUM(AVAL).

Input: laboratory (LB) records carrying the study and subject identifiers, the test code (LBTESTCD) used for the parameter code, and the collected numeric result (LBSTRESN).

Variables:

  • AVAL would be the collected numeric result from LBSTRESN; missing when the collected result is missing.
  • AVALTOT would be the total of AVAL across the subject's records, repeated on each record for that subject.

SUM(AVAL) is written as a row formula, but a row formula sees one record at a time and cannot reach the other records it would have to total, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Use an aggregate and state the subject-level keys explicitly:

derivation:
  aggregate:
    group_by: [STUDYID, USUBJID]
    expr: "SUM(AVAL)"

The total is then broadcast to each parameter row for that subject.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
prohibited_function
requirement
REQ-0440
expected/error.yaml
phase: validation
condition: prohibited_function
spec_paths:
  - columns.AVALTOT.derivation.compute.expr
requirement: REQ-0440
context:
  expr: "SUM(AVAL)"
  function: SUM

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDLBSTRESN
PILOT7ALT42
PILOT7AST31

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBAVALTOTTotal Analysis ValuenumericCompute SUM(AVAL).Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml