Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: rank each subject's adverse events (AEs) by reported severity, carrying through AESEV and numbering the events in SEVRANK.

Input: collected adverse event records carrying the reported severity (AESEV).

Variables:

  • SEVRANK would be the number of the event among the subject's events ordered by severity, worst first, with equally severe events sharing one number so they compare as equal. An event with no reported severity would come after every rated one.

Note: the tie-numbering choice arrives as a structured value instead of one of the two named methods. No reader may guess which method a structure means, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide how ties consume numbers, then name the method. When equally severe events share the lowest position they occupy and the next severity continues after the gap, write it plainly:

- name: SEVRANK
  type: int
  derivation:
    rank:
      method: competition
      window:
        group_by: [STUDYID, USUBJID]
        order_by:
          - {variable: AESEV, direction: desc}

When no numbers may be skipped, name the dense method instead. Do not encode the choice in a structure the vocabulary does not define.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_field_type
requirement
REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
  - columns.SEVRANK.derivation.rank.method
requirement: REQ-0287
context:
  expected: str
  actual: mapping

Inputs

Under review
1 source file

input/ae.csv

Edit
2 rows
input/ae.csv
STUDYIDUSUBJIDAESEQAESEV
PILOT71MODERATE
PILOT72SEVERE

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEAESEQSequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEAESEVSeveritycharacterCopy value from AE.AESEV.Predecessor
ADAESEVRANKSeverity RanknumericRank rows from 1 within each group of STUDYID, USUBJID, ordered by AESEV descending; ties share a number and the next distinct value follows without a gap.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml