Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry the systolic blood pressure (SYSBP) forward so the prior systolic pressure (PRIORBP) holds the closest earlier taken pressure for the same subject.

Input: collected vital signs records, each holding a systolic blood pressure (SYSBP); the value is missing when the measurement was not taken.

Variables:

  • PRIORBP would hold the closest earlier taken pressure for the same subject, in sequence-number order, and be missing when no earlier pressure was taken.

Note: the carried value arrives as the fixed number 120 instead of a variable to search, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide which earlier measurement the study carries, then name the variable that holds it. When the closest earlier taken pressure is the rule, search the pressure variable itself:

- name: PRIORBP
  type: int
  derivation:
    previous_non_missing:
      source: SYSBP
      window:
        group_by: [STUDYID, USUBJID]
        order_by: [VSSEQ]

When every gap should instead read a fixed fallback, state that as a separate rule over the carried result rather than inside the search.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_field_type
requirement
REQ-0287
expected/error.yaml
phase: validation
condition: invalid_field_type
spec_paths:
  - columns.PRIORBP.derivation.previous_non_missing.source
requirement: REQ-0287
context:
  expected: variable
  actual: mapping

Inputs

Under review
1 source file

input/vs.csv

Edit
3 rows
input/vs.csv
STUDYIDUSUBJIDVSSEQSYSBP
PILOT71128
PILOT72—
PILOT73132

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADVSSTUDYIDStudy IdentifiercharacterCopy value from VS.STUDYID.Predecessor
ADVSUSUBJIDUnique Subject IdentifiercharacterCopy value from VS.USUBJID.Predecessor
ADVSVSSEQSequence NumbernumericCopy value from VS.VSSEQ.Predecessor
ADVSSYSBPSystolic Blood PressurenumericCopy value from VS.SYSBP.Predecessor
ADVSPRIORBPPrior Systolic Blood PressurenumericMost recent non-missing {'literal': 120} from an earlier row within each group of STUDYID, USUBJID, ordered by VSSEQ.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml